Opened on 12/04/2017 at 01:41:58 PM
Closed on 09/07/2018 at 05:21:07 PM
#6137 closed defect (worksforme)
Whitelisted website message is being persistent
| Reported by: | saroyanm | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner, arthur | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by saroyanm)
Environment
Firefox: v57
ABP v: 3.0.1.1939beta
How to reproduce
- Open options page
- In Whitelisted websites tab whitelist example.com
- In Advanced tab Add @@||google.com$document filter in CREATE AND EDIT YOUR FILTER LIST section
- Reload the options page
- Observe
Observed behaviour
- "example.com" has been whitelisted. message is being show on every reload
Expected behaviour
- No whitelisting message on page reload
Attachments (0)
Change History (7)
comment:1 in reply to: ↑ description ; follow-up: ↓ 2 Changed on 12/04/2017 at 01:44:35 PM by saroyanm
comment:2 in reply to: ↑ 1 ; follow-up: ↓ 3 Changed on 12/04/2017 at 03:18:45 PM by greiner
Replying to saroyanm:
Replying to saroyanm:
- google.com is added into Whitelisted websites table
@Thomas can you please let me know if you agree to the current statement.
We currently specifically checking ^ to precede the $document (^@@\|\|([^/:]+)\^\$document$)
The filter in step (3) should be @@||google.com^$document instead of @@||google.com$document or otherwise it won't be recognized as a filter for the website whitelist. AFAIK the ^ before $document is necessary for indicating the end of the domain.
comment:3 in reply to: ↑ 2 Changed on 12/04/2017 at 03:58:26 PM by saroyanm
- Component changed from Unknown to User-Interface
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
Replying to greiner:
Replying to saroyanm:
Replying to saroyanm:
- google.com is added into Whitelisted websites table
@Thomas can you please let me know if you agree to the current statement.
We currently specifically checking ^ to precede the $document (^@@\|\|([^/:]+)\^\$document$)
The filter in step (3) should be @@||google.com^$document instead of @@||google.com$document or otherwise it won't be recognized as a filter for the website whitelist. AFAIK the ^ before $document is necessary for indicating the end of the domain.
Okey I wasn't sure if that suppose to not show in the Whitelisted websites, I've updated the ticket accordingly.
@Arthur please let me know if you think this should rather go to the Whitelisted websites tab.
comment:4 Changed on 12/05/2017 at 08:56:08 AM by arthur
I think the behaviour should stay like that.
comment:5 follow-up: ↓ 6 Changed on 09/07/2018 at 03:01:50 PM by greiner
@saroyanm Is this issue still reproducible? I vaguely remember that we fixed something along those lines a while back.
comment:6 in reply to: ↑ 5 Changed on 09/07/2018 at 03:43:46 PM by saroyanm
Replying to greiner:
@saroyanm Is this issue still reproducible? I vaguely remember that we fixed something along those lines a while back.
Hmm, that's a good point, I also remember that, but for some reason I can't find where we have fixed that,
AFAIK this was a Race condition bug, also I'm not able to reproduce this issue anymore.
comment:7 Changed on 09/07/2018 at 05:21:07 PM by greiner
- Resolution set to worksforme
- Status changed from new to closed
Thanks for checking. In that case let's close this ticket.
We can just create a new ticket or reopen this one if we encounter it again.
Replying to saroyanm:
@Thomas can you please let me know if you agree to the current statement.
We currently specifically checking ^ to precede the $document (^@@\|\|([^/:]+)\^\$document$)