Opened on 12/05/2017 at 01:54:11 PM
Closed on 12/14/2017 at 10:36:58 AM
Last modified on 12/14/2017 at 10:39:04 AM
#6142 closed change (rejected)
Let ensure_dependencies.py respect -q while trying to install nodejs
| Reported by: | tlucas | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | ferris, kvas | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
Some of our servers currently have Node.js installed, some do not.
Those servers without Node.js installed currently spam monitoring with notifications about missing Node.js but other run their tasks as expected.
What to change
Let ensure_dependencies.py respect the -q parameter when trying to install Node.js dependencies. i.e. suppress the notification Failed to install Node.js dependencies for %s, please ensure Node.js is installed.
Attachments (0)
Change History (6)
comment:1 Changed on 12/05/2017 at 01:54:18 PM by tlucas
- Owner set to tlucas
comment:3 in reply to: ↑ 2 Changed on 12/05/2017 at 02:20:07 PM by kvas
Replying to sebastian:
Perhaps a better approach would be to only run npm install if there is actually a packages.json.
I think that's already working this way. However, we have a situation where we have a packages.json but failing to install those dependencies is not a problem on some (most) servers because they don't use the particular scripts that require Node.js.
comment:4 Changed on 12/05/2017 at 02:37:03 PM by tlucas
For reference:
http://hub.eyeo.com/issues/5876
comment:5 Changed on 12/14/2017 at 10:36:58 AM by tlucas
- Resolution set to rejected
- Status changed from new to closed
comment:6 Changed on 12/14/2017 at 10:39:04 AM by tlucas
For reference: http://hub.eyeo.com/issues/5944#change-20299
Perhaps a better approach would be to only run npm install if there is actually a packages.json. If there is none, there is no point in running npm install in the first place, but if there is one merely suppressing the error will just cause other issues down the road.