Opened on 12/05/2017 at 03:49:25 PM
Closed on 12/05/2017 at 04:28:23 PM
Last modified on 12/08/2017 at 03:11:39 PM
#6163 closed change (fixed)
Fix incorrect source strings in Options page project
| Reported by: | lisabielik | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | sebastian, trev, Shikitita, saroyanm | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
For some reason, apostrophes were added to the English source strings:
We noticed you have both '<strong>$tracking$</strong>' and '<strong>$acceptableAds$</strong>' enabled.
AND
If you prefer extra privacy, select the '<strong>$acceptableAdsPrivacy$</strong>' checkbox below.
The apostrophes need to be removed, as it doesn't make sense to have things bolded and quoted.
What to change
Remove apostrophes ('/') from both strings:
We noticed you have both <strong>$tracking$</strong> and <strong>$acceptableAds$</strong> enabled.
If you prefer extra privacy, select the <strong>$acceptableAdsPrivacy$</strong> checkbox below.
Attachments (0)
Change History (7)
comment:1 Changed on 12/05/2017 at 03:59:55 PM by saroyanm
- Owner set to saroyanm
- Priority changed from Unknown to P1
- Ready set
comment:2 Changed on 12/05/2017 at 04:05:43 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 12/05/2017 at 04:11:07 PM by abpbot
A commit referencing this issue has landed:
Issue 6163 - Fix incorrect source strings in Options page project
comment:4 Changed on 12/05/2017 at 04:28:23 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 12/05/2017 at 06:40:18 PM by trev
Before we give these strings to translators again, can we please make sure to make them proper first? Combining multiple strings into one the way this was done here is a huge footgun. In many languages, declination makes it impossible to insert the acceptableAds string without changes. Translators need to use tricks, e.g. in Russian I had to say "and the feature $acceptableAds$" to make it work. And I doubt that every translator even noticed the issue here.
comment:7 Changed on 12/08/2017 at 03:11:39 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed.
ABP 3.0.1.1943
Firefox 51 / 57 / Windows 10
Created Bitbucket issue to reflect the changes
https://bitbucket.org/adblockplus/spec/issues/115/remove-apostrophes-from-the-conflict