Opened on 12/06/2017 at 03:00:25 PM

Closed on 08/30/2019 at 04:10:17 PM

#6167 closed defect (duplicate)

Release automation fails on Windows

Reported by: Ross Assignee:
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: Sebastian, tlucas Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

Windows 10
Python 2.7

How to reproduce

  1. Setup repositories as described in #5994.
  2. Attempt to run release automation as described in #5994.

Observed behaviour

The release automation fails on Windows with the error:

Traceback (most recent call last):
  File "D:\dev\scratch5994\adblockpluschrome\build.py", line 17, in <module>
        import buildtools.build
  File "D:\dev\scratch5994\adblockpluschrome\buildtools\build.py", line 139, in <module>
    make_argument('output_file', nargs='?')
  File "D:\dev\scratch5994\adblockpluschrome\buildtools\build.py", line 42, in wrapper
    short_desc, long_desc = func.__doc__.split(os.linesep + os.linesep, 1)
ValueError: need more than 1 value to unpack

Expected behaviour

Release automation to successfully run on Windows too. We should probably split using regex as described by Wladimir here.

Attachments (0)

Change History (3)

comment:1 Changed on 12/08/2017 at 11:02:03 AM by tlucas

  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 12/21/2017 at 11:29:03 AM by fhd

  • Cc trev removed

comment:3 Changed on 08/30/2019 at 04:10:17 PM by sebastian

  • Resolution set to duplicate
  • Status changed from new to closed

I didn't confirm if the above error can still be reproduced, but at the moment the biggest blocker preventing Adblock Plus form even building on native Windows is #6587. Also the Python-based release automation is to be discontinued, see #7120, and we avoid touching the code for the time being.

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
 
Note: See TracTickets for help on using tickets.