Opened on 12/07/2017 at 02:28:12 PM

Closed on 12/08/2017 at 01:31:02 PM

Last modified on 12/11/2017 at 10:06:58 AM

#6173 closed change (fixed)

Import Options page title translations

Reported by: saroyanm Assignee: saroyanm
Priority: P2 Milestone:
Module: User-Interface Keywords:
Cc: Shikitita, kzar, sebastian Blocked By:
Blocking: #6178 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29632580/

Description

Background

With #5972 we have fixed wrong options page title in the extension, but we didn't yet imported the translations for that string from the crowdin

What to change

Import translations for options page title

Attachments (0)

Change History (6)

comment:1 Changed on 12/07/2017 at 02:28:21 PM by saroyanm

  • Owner set to saroyanm

comment:2 Changed on 12/07/2017 at 02:28:31 PM by saroyanm

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:3 Changed on 12/08/2017 at 01:10:49 PM by abpbot

A commit referencing this issue has landed:
Issue 6173 - import options page title translations

comment:4 Changed on 12/08/2017 at 01:27:44 PM by kzar

  • Blocking 6178 added

comment:5 Changed on 12/08/2017 at 01:31:02 PM by saroyanm

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 12/11/2017 at 10:06:58 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Done. Options page title is translated.

ABP 3.0.1.1943
Firefox 52 / 57 / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from saroyanm.
 
Note: See TracTickets for help on using tickets.