Opened on 12/11/2017 at 03:31:41 PM

Closed on 01/05/2018 at 07:59:09 AM

#6182 closed change (fixed)

Add build step for fonts and images in help.eyeo.com

Reported by: ire Assignee: ire
Priority: P3 Milestone: help.eyeo.com 1.0.0
Module: Websites Keywords:
Cc: juliandoucette, wspee Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29637578/

Description (last modified by ire)

Background

In #6104 we added a build step to minify our SCSS and JS files.

What to change

Add a build step for the other static assets we have (fonts and images), so everything in the dist directory is generated and never manually manipulated

Attachments (0)

Change History (5)

comment:1 Changed on 12/12/2017 at 10:28:22 AM by ire

  • Description modified (diff)
  • Ready set

comment:2 Changed on 12/13/2017 at 11:48:27 AM by ire

  • Owner set to ire

comment:3 Changed on 12/13/2017 at 12:15:52 PM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 01/05/2018 at 07:57:15 AM by abpbot

A commit referencing this issue has landed:
Issue 6182 - Add build step for fonts and images in help.eyeo.com

comment:5 Changed on 01/05/2018 at 07:59:09 AM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
 
Note: See TracTickets for help on using tickets.