Opened on 12/12/2017 at 01:56:02 PM

Closed on 12/19/2017 at 09:45:36 AM

Last modified on 01/08/2018 at 05:40:01 PM

#6187 closed change (fixed)

Adjust query string parameters for Yandex

Reported by: mario Assignee: jwangenheim
Priority: Unknown Milestone: Adblock-Plus-for-Samsung-Browser-1.1.3
Module: Adblock-Plus-for-Samsung-Browser Keywords:
Cc: Blocked By:
Blocking: Platform: Samsung Browser
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

https://codereview.adblockplus.org/29640558/

Description

Background

Yandex has recently started to support content blocking functionality in Yandex Browser for Android. They support all Samsung Internet content blockers out of the box and thus ABP for Samsung Internet is available within Yandex as well.
In order to differentiate between both, we'll need to adjust ABP for Samsung Internet's query string parameters while fetching filter lists.

What to change

  1. If ABP for Samsung Internet is used with Yandex, set the query string application to yandex
  2. If ABP for Samsung Internet is used with Samsung Internet, set the query string application to sbrowser
  3. If ABP for Samsung Internet is used with Yandex and Samsung Internet, set the query string application to sbrowseryandex

Attachments (0)

Change History (7)

comment:1 Changed on 12/15/2017 at 03:50:50 PM by jwangenheim

  • Ready set

comment:2 Changed on 12/15/2017 at 03:50:54 PM by jwangenheim

  • Owner set to jwangenheim

comment:3 Changed on 12/18/2017 at 08:46:07 AM by jwangenheim

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 12/19/2017 at 09:43:19 AM by abpbot

A commit referencing this issue has landed:
Issue 6187 - Adjust query string parameters for Yandex

comment:5 Changed on 12/19/2017 at 09:45:36 AM by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:6 Changed on 12/19/2017 at 11:21:59 AM by jwangenheim

  • Milestone set to Adblock-Plus-for-Samsung-Browser-next

comment:7 Changed on 01/08/2018 at 05:40:01 PM by traynard

  • Verified working set

LGTM

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jwangenheim.
 
Note: See TracTickets for help on using tickets.