Opened on 12/12/2017 at 03:57:10 PM
Closed on 01/15/2018 at 12:41:46 PM
Last modified on 04/23/2018 at 07:09:47 PM
#6191 closed defect (fixed)
"Block Element" button shown for Chrome webstore
| Reported by: | kzar | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | sebastian, mjethani | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Environment
Chrome 62, adblockpluschrome 62e3fd8a8949, Debian Buster
How to reproduce
- Open a new tab.
- Navigate to https://reddit.com
- Click the ABP logo, notice the "Block Element" button is displayed
- Navigate to https://chrome.google.com/webstore/category/extensions
- Click the ABP logo again.
Observed behaviour
The "Block Element" button is still displayed, clicking it doesn't work properly since our content scripts aren't injected since it's a special protected page.
Expected behaviour
The "Block Element" button isn't displayed for the Chrome Web store.
Notes
- We noticed this while looking into #6183.
Attachments (0)
Change History (7)
comment:1 Changed on 12/21/2017 at 11:30:13 AM by fhd
- Cc trev removed
comment:2 Changed on 12/21/2017 at 11:30:53 AM by mjethani
- Owner set to mjethani
comment:3 Changed on 01/15/2018 at 12:40:15 PM by abpbot
comment:4 Changed on 01/15/2018 at 12:41:46 PM by mjethani
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from new to closed
comment:5 Changed on 02/08/2018 at 01:34:39 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Block element does not appear for Chrome web store pages. It does in FF/Opera, but I'm guessing it is not a protected page in non-Chrome.
ABP 3.0.2.1968
Chrome 64 / 49 / Canary (66) / Windows 7
Opera 49 / 36 / Beta (52) / Windows 7
Firefox 58 / 51 / Beta (59) / Windows 7
comment:6 Changed on 04/23/2018 at 01:51:22 PM by philll
I suspect we may have some regression here: https://adblockplus.org/forum/viewtopic.php?f=10&t=55379
A commit referencing this issue has landed:
Issue 6191 - Update frame structure for Chrome Web Store pages