Opened on 12/18/2017 at 09:20:46 AM

Closed on 01/09/2018 at 02:41:22 PM

#6203 closed defect (fixed)

Fix rule-empty-line-before in stylelint-config-eyeo

Reported by: ire Assignee: ire
Priority: P3 Milestone:
Module: Websites Keywords:
Cc: saroyanm, greiner, martin, p.pastourmatzis, erick, fhd, juliandoucette Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29643571

Description

Environment

Any

How to reproduce

  1. Follow the instructions to install stylelint-config-eyeo from codingtools
  2. Run the stylelint command with any CSS file

Observed behaviour

See error:

Invalid Option: Invalid value "first-nested" for option "ignore" of rule "rule-empty-line-before"

Expected behaviour

The first-nested rule should be an option for except within the rule rule-empty-line-before.

What to do

Change the rule-empty-line-before to the following:

    // Separate rules by an empty line
    "rule-empty-line-before": ["always", {
      "ignore": ["after-comment"],
      "except": ["first-nested"]
    }],

Attachments (0)

Change History (3)

comment:1 Changed on 12/18/2017 at 09:42:20 AM by ire

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/09/2018 at 02:39:18 PM by abpbot

A commit referencing this issue has landed:
​Issue 6203 - Fix rule-empty-line-before in stylelint-config-eyeo

comment:3 Changed on 01/09/2018 at 02:41:22 PM by ire

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ire.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.