Opened on 12/21/2017 at 03:15:53 PM

Closed on 01/10/2018 at 02:29:06 PM

#6214 closed change (fixed)

Configure libadblockplus binaries directory

Reported by: asmirnov Assignee:
Priority: P2 Milestone:
Module: Libadblockplus-Android Keywords:
Cc: sergz Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29646595/

Description

Background

In order to save compilation time we do precompile libadblockplus and store it in libadblockplus-binaries repository (eg. ​https://github.com/adblockplus/libadblockplus-binaries). It's extracted by default into libadblockplus-android/jni/libadblockplus-binaries directory (written in dependencies file). However if we link with external V8 it can be not desired for CI or some complex build scenarios like building as Chromium submodule.

What to change

Add argument to configure shared libraries path or use default value.

Attachments (0)

Change History (3)

comment:1 Changed on 12/21/2017 at 03:23:03 PM by asmirnov

  • Cc sergz added
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/10/2018 at 02:26:30 PM by abpbot

Some commits referencing this issue have landed:

comment:3 Changed on 01/10/2018 at 02:29:06 PM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.