Opened on 12/28/2017 at 08:58:57 PM

Closed on 01/07/2018 at 11:55:52 PM

#6223 closed change (fixed)

Update filter list model to support conversion of Objective-C Adblock Plus classes

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: #5551 Platform: iOS
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29650555/

Description

Background

A few changes are needed in the Swift model to support conversion of AdblockPlusExtras.

What to change

  • Add a property for filter list name.
  • Change task identifiers to Ints for easier interoperation with Objective-C.
  • Add an expired function.

Attachments (0)

Change History (2)

comment:1 Changed on 12/28/2017 at 09:30:20 PM by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/07/2018 at 11:55:52 PM by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from dzhang.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.