Opened on 01/08/2018 at 07:03:51 PM
Closed on 01/17/2018 at 07:29:34 AM
#6235 closed defect (fixed)
Reinstall button on uninstallation page is below the fold
| Reported by: | greiner | Assignee: | ire |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Websites | Keywords: | |
| Cc: | juliandoucette, jeen, ire | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Environment
Ubuntu 16.04 (1368x768)
Chrome 62
How to reproduce
Go to https://adblockplus.org/en/uninstalled
Observed behaviour
"Reinstall Now" button is below the fold. It looks like there's nothing relevant below the form anymore so I wouldn't scroll down to discover the button either.
See attachment.
Expected behaviour
"Reinstall Now" button is above the fold.
Further information
According to Stat Counter, 1366x768 is still the most popular resolution on desktop devices.
Attachments (2)
Change History (11)
Changed on 01/08/2018 at 07:04:27 PM by greiner
comment:2 Changed on 01/15/2018 at 03:40:59 PM by ire
- Cc jeen ire added
@jeen Could we get your input on this? From what I have seen in the specification we don't yet have a mockup/spec for what this page should look like.
comment:3 follow-up: ↓ 4 Changed on 01/15/2018 at 03:46:09 PM by jeen
Ah, thanks for highlighting this. It appears above the fold for me - but agreed, for smaller screen sizes this will be a problem.
I would suggest moving it to just below the main nav instead.
comment:4 in reply to: ↑ 3 Changed on 01/15/2018 at 04:43:06 PM by ire
- Owner set to ire
- Priority changed from Unknown to P3
- Ready set
Replying to jeen:
Ah, thanks for highlighting this. It appears above the fold for me - but agreed, for smaller screen sizes this will be a problem.
I would suggest moving it to just below the main nav instead.
Alright, thanks!
comment:5 Changed on 01/15/2018 at 04:48:03 PM by ire
- Review URL(s) modified (diff)
- Status changed from new to reviewing
Changed on 01/15/2018 at 06:01:16 PM by ire
Blue reinstall banner below header
comment:6 Changed on 01/15/2018 at 06:02:11 PM by ire
From codereview:
On 2018/01/15 17:23:13, juliandoucette wrote:
- Now it's inconsistent across pages (unintsalled-submit)
- These colors clash
- I think we should show Jeen and suggest black or gray or otherwise
@jeen, what do you think? (I've attached a screenshot of what it looks like in my current implementation)
comment:7 Changed on 01/16/2018 at 08:24:05 AM by jeen
yes looks good! I'll notify the data team as well to monitor the reinstall rates once this has been implemented
comment:8 Changed on 01/17/2018 at 07:28:58 AM by abpbot
A commit referencing this issue has landed:
Issue 6235 - Reinstall button on uninstallation page is below the fold
comment:9 Changed on 01/17/2018 at 07:29:34 AM by ire
- Resolution set to fixed
- Status changed from reviewing to closed
Added reference to attachment to ticket description.