Opened on 01/12/2018 at 10:20:49 AM

Closed on 02/28/2018 at 02:03:57 PM

#6244 closed defect (fixed)

FavIcon: Tests to be fixed

Reported by: ashephard Assignee: ashephard
Priority: Unknown Milestone: Adblock-Plus-for-iOS-next
Module: Unknown Keywords:
Cc: Blocked By:
Blocking: #6245, #6262 Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29664565/

Description

The tests in the FavIcon library are currently not working due to a change in logic in the FavIcon.swift class
Both the tests class and the FavIcon.swift class need to be updated in order to repair the failing tests.

Attachments (0)

Change History (4)

comment:1 Changed on 01/12/2018 at 10:33:00 AM by ashephard

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/12/2018 at 10:34:49 AM by ashephard

  • Blocking 6245 added

comment:3 Changed on 01/15/2018 at 06:01:37 PM by dzhang

  • Blocking 6262 added

comment:4 Changed on 02/28/2018 at 02:03:57 PM by ashephard

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from ashephard.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.