Opened on 01/12/2018 at 08:11:15 PM

#6256 new change

Change the visibility property of style objects without JS

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Background

Currently we generate JavaScript as string and then run JS in isolated world to change nodes visibility:
​https://gitlab.com/adblockplus/chromium/blob/abp/chrome/browser/android/adblock/adblock_bridge.cc#L80

So JS is passed to child process, parsed and executed by V8 and then actually it just changes node objects "visibility" property. It would be better to change them directly without need to generate/parse JS as string.
However it can require IPC to be changed/messages added.

What to change

Change CSS style "visibility" property without JS

Attachments (0)

Change History (0)

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.