Context Navigation

Opened on 01/12/2018 at 08:23:44 PM

Last modified on 01/22/2018 at 10:39:22 AM

#6258 new change

In order to make java/c++ interaction easier i had to use global variables (AdblockBridge::filterEnginePtr and below):
https://gitlab.com/adblockplus/chromium/blob/abp/chrome/browser/android/adblock/adblock_bridge.cc#L278

That worked great for simplicity and making proof-of-concept but i don't like it. I'd prefer better solution.

Refactor a bit - move global variables to some class members.

Summary changed from Refactor using global variables to Refactor usage of global variables

You may use WikiFormatting here.

Change Properties

Summary:
Description:	You may use WikiFormatting here. === Background === In order to make java/c++ interaction easier i had to use global variables (`AdblockBridge::filterEnginePtr` and below): https://gitlab.com/adblockplus/chromium/blob/abp/chrome/browser/android/adblock/adblock_bridge.cc#L278 That worked great for simplicity and making proof-of-concept but i don't like it. I'd prefer better solution. === What to change === Refactor a bit - move global variables to some class members.
Type:		Priority:
Milestone:		Module:
Keywords:		Cc:
Blocked By:		Blocking:
Platform:		Ready:
Confidential:		Tester:
Verified working:
Review URL(s):

Action

leave as new .

resolve as The resolution will be set. Next status will be 'closed'.

reassign to The owner will be changed from (none).

codereview Next status will be 'reviewing'.

Attachments ↑ Description ↑

Note: See TracTickets for help on using tickets.