Opened on 01/15/2018 at 05:48:02 AM
Closed on 01/15/2018 at 06:08:20 AM
Last modified on 01/16/2018 at 05:50:23 AM
#6263 closed change (fixed)
Build libadblockplus and libadblockplus-android while building Chromium
| Reported by: | asmirnov | Assignee: | |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Adblock-Plus-for-Chromium | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6248, #6249, #6257, #6260, #6264, #6272 | Platform: | Android |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
libadblockplus have to be compiled with Chromium's V8 and libadblockplus-android have to be linked with that libadblockplus and Chromium's V8. This can be done on dev machine (not AdblockChromium's build VM) by extracting exactly the same revision of deps that are used in Chromium (and can depend on exact Chromium revision).
For libadblockplus-android SHARED_V8_LIB_FILENAMES have to be used (and SHARED_V8_LIB_DIR optionally).
This can be done automatically when building Chromium by adding to DEPS and BUILD.gn. However it can be tricky to replace building with GN (to do the same as Gradle done in essence). So reusing existing build tools/scripts can help.
What to change
Update Chromium dependencies, hooks and GN build rules.
Attachments (0)
Change History (7)
comment:1 Changed on 01/15/2018 at 05:49:40 AM by asmirnov
- Blocking 6260 added
comment:2 Changed on 01/15/2018 at 05:50:12 AM by asmirnov
- Blocking 6248 added
comment:3 Changed on 01/15/2018 at 05:50:27 AM by asmirnov
- Blocking 6249 added
comment:4 Changed on 01/15/2018 at 05:51:00 AM by asmirnov
- Blocking 6257 added
comment:5 Changed on 01/15/2018 at 06:08:20 AM by asmirnov
- Resolution set to fixed
- Status changed from new to closed
comment:6 Changed on 01/15/2018 at 06:27:14 AM by asmirnov
- Blocking 6264 added
comment:7 Changed on 01/16/2018 at 05:50:23 AM by asmirnov
- Blocking 6272 added
