Opened on 01/16/2018 at 11:49:47 AM

Closed on 01/19/2018 at 06:17:59 AM

#6277 closed change (fixed)

Subproc.py should wait for subprocess to finish

Reported by: asmirnov Assignee:
Priority: P2 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29670584/

Description

Background

Subproc.py is used in libadblockplus and libadblockplus-android to start subprocess to build with external build tool. At the moment it does not wait for process to finish allowing do it concurrently. But this leads to incorrect subprocess returncode returned (always 0).

What to change

Modify subprocess.py to wait for subprocess to finish.

Attachments (0)

Change History (2)

comment:1 Changed on 01/16/2018 at 12:03:50 PM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 01/19/2018 at 06:17:59 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.