Opened on 01/17/2018 at 09:12:47 AM

Closed on 01/18/2018 at 01:15:48 PM

Last modified on 06/05/2018 at 11:19:07 PM

#6283 closed defect (fixed)

Adjust text highlight and text select handle colors

Reported by: jwangenheim Assignee: jwangenheim
Priority: P4 Milestone: Adblock-Browser-for-Android-1.4.0
Module: Adblock-Browser-for-Android Keywords:
Cc: diegocarloslima, tpregueiro, mario Blocked By:
Blocking: Platform: Adblock Browser for Android
Ready: yes Confidential: no
Tester: Unknown Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29671566/

Description

Environment

ABB version 1.3.3 on OnePlus 5 with Android 8

How to reproduce

  1. Go to a website that contains text
  2. Select text
  3. The selected text is highlighted and text select handles are displayed

Observed behaviour

Text highlighting and text select handles are orange

Expected behaviour

Text highlighting and text select handles are blue

Attachments (0)

Change History (5)

comment:1 Changed on 01/17/2018 at 09:32:18 AM by jwangenheim

  • Review URL(s) modified (diff)

comment:2 Changed on 01/17/2018 at 10:33:18 AM by jwangenheim

  • Status changed from new to reviewing

comment:3 Changed on 01/18/2018 at 01:13:49 PM by abpbot

A commit referencing this issue has landed:
​Issue 6283 - Adjust text highlight and text select handle colors

comment:4 Changed on 01/18/2018 at 01:15:48 PM by jwangenheim

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 06/05/2018 at 11:19:07 PM by traynard

  • Verified working set

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from jwangenheim.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.