Opened on 01/19/2018 at 02:14:14 PM
Closed on 08/09/2018 at 07:10:35 AM
Last modified on 10/08/2019 at 06:03:59 PM
#6291 closed defect (fixed)
Fix Windows Store devbuild upload routine
| Reported by: | oleksandr | Assignee: | tlucas |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | Automation | Keywords: | |
| Cc: | tlucas, sebastian | Blocked By: | |
| Blocking: | Platform: | Edge | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29751598/ |
||
Description
We have automated uploads to the Windows Store of our Edge devbuilds in #4549. For that, we needed to set up credentials, as described in #4909.
Currently the authentication to Windows Store is implemented through the refresh token mechanism. Unfortunately there is a rather short expiration time of refresh tokens from Windows Store (14 days). Because of that we quite often have to re-acquire the refresh token. This is why we need to switch to using certificate credentials instead, which do not expire.
The workflow is described here. There is also a sample Python code for acquiring a token using client certificate here.
Attachments (0)
Change History (12)
comment:1 Changed on 03/22/2018 at 06:15:50 PM by sebastian
- Cc sebastian added
- Component changed from Sitescripts to Automation
- Priority changed from Unknown to P2
comment:2 Changed on 03/23/2018 at 11:13:36 AM by tlucas
- Owner set to tlucas
comment:3 Changed on 04/13/2018 at 01:06:12 PM by tlucas
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 04/30/2018 at 05:15:46 PM by abpbot
comment:5 Changed on 04/30/2018 at 05:16:38 PM by tlucas
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 follow-up: ↓ 7 Changed on 05/18/2018 at 01:09:12 PM by tlucas
- Resolution fixed deleted
- Status changed from closed to reopened
comment:7 in reply to: ↑ 6 Changed on 05/18/2018 at 01:10:02 PM by tlucas
Replying to tlucas:
We successfully authenticate with the Windows Store - but our builds currently get rejected, hence are not published.
comment:8 Changed on 06/14/2018 at 04:11:33 PM by sebastian
As far as I understand, the problem isn't limited to the automated devbuild upload, but the builds generated with build.py build aren't accepted either when manually uploaded to the Windows Store.
For reference, in the meanwhile we used ManifoldJS to generate release and test builds. We could consider integrating ManifoldJS in buildtools, if it no longer requires Windows (?).
comment:10 Changed on 08/09/2018 at 07:10:12 AM by abpbot
A commit referencing this issue has landed:
Issue 6291 - add ManifoldJS packaging for Edge
comment:11 Changed on 08/09/2018 at 07:10:35 AM by tlucas
- Resolution set to fixed
- Status changed from reopened to closed
comment:12 Changed on 08/28/2019 at 08:53:05 AM by siva123prasad
spam
A commit referencing this issue has landed:
Issue 6291 - Use client certificate for Windows Store uploads