Opened on 01/19/2018 at 10:39:32 PM
Closed on 01/20/2018 at 10:10:10 PM
#6293 closed change (fixed)
Include all false positives with report digest
Reported by: | paco | Assignee: | paco |
---|---|---|---|
Priority: | Unknown | Milestone: | |
Module: | Sitescripts | Keywords: | |
Cc: | kvas | Blocked By: | |
Blocking: | Platform: | Unknown / Cross platform | |
Ready: | yes | Confidential: | no |
Tester: | Unknown | Verified working: | no |
Review URL(s): |
Description
Thus far we where only including false positive issue reports with the filter list maintainer digests when their data record featured at least one matching filter. Now ever since we've switched to Web Extensions on Firefox the required information is not aggregated or included any more. Hence we should remove said constraint in order to ensure all issue reports being visible and processed.
$ sudo hg -R /opt/sitescripts diff diff --git a/sitescripts/reports/bin/updateDigests.py b/sitescripts/reports/bin/updateDigests.py --- a/sitescripts/reports/bin/updateDigests.py +++ b/sitescripts/reports/bin/updateDigests.py @@ -66,7 +66,7 @@ subscriptionID = subscription.get('url', 'unknown') # Send false negatives to all subscription authors, false positives # only to subscriptions with matching filters - if subscriptionID in subscriptions and (dbreport['type'] == 'false negative' or subscription.get('hasmatches', 0) > 0): + if subscriptionID in subscriptions: name, email = parseaddr(subscriptions[subscriptionID].email) if email and not email in recipients: recipients.add(email)
Attachments (0)
Change History (2)
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6293 - Include all false positives with report digest