Opened on 01/22/2018 at 06:55:56 PM
Closed on 01/30/2018 at 08:00:51 PM
Last modified on 02/08/2018 at 02:01:57 PM
#6298 closed defect (fixed)
White pages displayed in current version of Chrome Canary with Adblock Plus enabled
| Reported by: | weissmar | Assignee: | mjethani |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Plus-3.0.3-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | mjethani, kzar, sebastian, mapx | Blocked By: | |
| Blocking: | Platform: | Chrome | |
| Ready: | no | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
I also reported this to Chromium: https://bugs.chromium.org/p/chromium/issues/detail?id=804407
Environment
UserAgent: Mozilla/5.0 (Windows NT 10.0; WOW64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/66.0.3328.1 Safari/537.36
Chrome version: 66.0.3328.1
OS Version: 10.0
ABP: 1.13.4
Filter lists: EasyList, Acceptable Ads
How to reproduce
- Open Chrome Canary (66.0.3328.1)
- Install AdBlock Plus
- On the chrome://extensions page, disable and then re-enable AdBlock Plus
- Navigate to any webpage (e.g. wikipedia.org)
Observed behaviour
A white page (without any content) is displayed. This happens whether or not ABP is blocking/hiding anything on the page.
Expected behaviour
The page (with all non-ad content) should be displayed.
Attachments (0)
Change History (19)
comment:1 Changed on 01/22/2018 at 11:42:40 PM by rscott
- Component changed from Unknown to Adblock-Plus-for-Chromium
- Platform changed from Unknown / Cross platform to Chrome
- Summary changed from White pages displayed in current version of Chrome Canary with AdBlock Plue enabled to White pages displayed in current version of Chrome Canary with AdBlock Plus enabled
comment:2 Changed on 01/22/2018 at 11:51:19 PM by rscott
comment:3 Changed on 01/23/2018 at 12:44:15 AM by hfiguiere
- Cc mjethani added
comment:4 follow-up: ↓ 5 Changed on 01/23/2018 at 06:45:24 AM by mjethani
- Summary changed from White pages displayed in current version of Chrome Canary with AdBlock Plus enabled to White pages displayed in current version of Chrome Canary with Adblock Plus enabled
This is a regression in Chromium and is being tracked at https://crbbug.com/804179
comment:5 in reply to: ↑ 4 Changed on 01/23/2018 at 10:57:54 AM by mjethani
Replying to mjethani:
This is a regression in Chromium and is being tracked at https://crbbug.com/804179
This is not a regression, the underlying issue exists in Chrome 63 as well. Adblock Plus just happens to have started using the tabs.insertCSS API in recent Canary builds. We may still be able to fix it in Chromium, but I think Adblock Plus should also implement a workaround in the meanwhile.
comment:6 Changed on 01/23/2018 at 10:58:43 AM by mjethani
- Cc kzar sebastian added
- Owner set to mjethani
comment:7 Changed on 01/24/2018 at 08:29:30 AM by mapx
- Cc mapx added
comment:8 Changed on 01/24/2018 at 01:39:53 PM by mapx
I cannot reproduce the issue in Version 66.0.3330.0 (Official Build) canary (64-bit)
Adblock Plus development build 3.0.2.1953
comment:9 Changed on 01/24/2018 at 02:58:49 PM by mjethani
@mapx I've uploaded a standalone test case, can you reproduce it with that one?
comment:10 Changed on 01/24/2018 at 02:58:55 PM by mjethani
I've submitted a patch to fix the issue in Chromium.
comment:11 Changed on 01/24/2018 at 03:06:02 PM by mapx
using that example I can reproduce the issue. However, ABP still works fine for me (+ easylist)
comment:12 Changed on 01/25/2018 at 06:07:52 AM by asmirnov
Guys, are you sure it's "Adblock-Plus-for-Chromium" ticket or "Chrome" ticket?
If you mean ABP plugin for Chrome you should change ticket module.
comment:13 Changed on 01/25/2018 at 10:40:42 AM by kzar
- Component changed from Adblock-Plus-for-Chromium to Platform
comment:14 Changed on 01/25/2018 at 04:12:07 PM by mjethani
@mapx it's still broken for me on Canary 66.0.3331.0
comment:15 Changed on 01/26/2018 at 11:10:17 AM by sebastian
For reference, as a quick fix, we will do an emergency release for Chrome and Opera, backporting #5695 on top of Adblock Plus 1.13.4. This will cause user stylesheets not being used on Chrome, for now. However, eventually we also want to leverage user stylesheets on Chrome, and therefore we seem to have to split up the selectors. Therefore I leave this issue open.
comment:16 Changed on 01/30/2018 at 07:51:06 PM by abpbot
A commit referencing this issue has landed:
Issue 6298 - Split injected CSS hiding rule into groups of 1,024 selectors
comment:17 Changed on 01/30/2018 at 08:00:51 PM by mjethani
- Resolution set to fixed
- Review URL(s) modified (diff)
- Status changed from new to closed
comment:18 Changed on 01/30/2018 at 08:01:56 PM by mjethani
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
comment:19 Changed on 02/08/2018 at 02:01:57 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Pages are no longer blank when using ABP in Chrome Canary.
ABP 3.0.2.1968
Chrome Canary (66) / Windows 7
Thanks for filing this bug report! =)
When I looked at this in Chrome Canary, it seemed as though disabling all blocking filters (eg Easylist) made the bug go away. When I installed a modified version of Easylist with all the element hiding filters removed, I didn't encounter this bug. So it seems something to do with the processing of element hiding filters is at fault.
It almost seems as though an element hiding filter hit causes much more than just that element to be blocked.
Also reported on Twitter. https://twitter.com/PremiumFrye/status/955466844013518848