Opened on 01/23/2018 at 12:51:54 PM
Closed on 04/16/2018 at 11:02:30 AM
#6303 closed change (fixed)
Introduce basic foundation for automation in adblockplusui
| Reported by: | greiner | Assignee: | agiammarchi |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | saroyanm, wspee, agiammarchi | Blocked By: | #6288 |
| Blocking: | #6117 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
We've agreed on using various tools to establish a more coherent experience throughout front-end projects. For now this means that we want to use Node, gulp, ESLint and Stylelint to establish some basic automation in adblockplusui, with more to follow later on.
For translations, it's not yet clear how we want to integrate buildtools into it though so we should probably keep it unchanged for now.
What to change
- Introduce package.json and define scripts for
- Running linters
- Starting test server (for now we can simply call test-server.py)
- Resolving buildtools dependency using the "prepare" name (for now we can simply call ensure-dependencies.py)
- Add development dependencies for linters so that we can resolve these dependencies automatically by running npm install
- Due to negative experiences, we should avoid including package-lock.json at this point (see #5856).
- Update README.md to reflect changes
Attachments (0)
Change History (8)
comment:1 Changed on 01/23/2018 at 01:42:46 PM by greiner
- Priority changed from Unknown to P3
- Ready set
comment:2 Changed on 01/23/2018 at 01:48:16 PM by agiammarchi
- Owner set to agiammarchi
comment:3 Changed on 01/23/2018 at 02:53:50 PM by agiammarchi
- Blocked By 6288 added
comment:4 Changed on 01/24/2018 at 04:07:27 PM by saroyanm
- Blocking 6117 added
comment:5 Changed on 01/26/2018 at 06:00:05 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 02/08/2018 at 03:47:11 PM by abpbot
A commit referencing this issue has landed:
Issue 6303 - Introduce basic foundation for automation in adblockplusui
comment:7 Changed on 03/28/2018 at 07:45:55 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done.
adblockplusui / 236:9546f62e182f
comment:8 Changed on 04/16/2018 at 11:02:30 AM by agiammarchi
- Resolution set to fixed
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
We've agreed on the proposed approach on IRC so marking it as "ready".