Opened on 01/25/2018 at 10:56:06 AM
Closed on 03/29/2018 at 08:43:16 AM
Last modified on 04/13/2018 at 10:41:36 AM
#6315 closed change (fixed)
Fix gyp and gtest usage comment
| Reported by: | asmirnov | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Adblock-Plus-for-Chromium | Keywords: | |
| Cc: | sergz | Blocked By: | |
| Blocking: | Platform: | Android | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/chromium/merge_requests/8 |
||
Description (last modified by asmirnov)
Background
We have to build V8 with libadblockplus. For this we have to prepare deps including gtest and gyp.
We're having comment "/third_party/libadblockplus/prepare_dependencies.py" about it that is not very clear.
What to change
Fix comment for gyp and gtest usage for V8 deps:
https://codereview.adblockplus.org/29674555/#msg13
Tips for testers
Since it does not relate to any feature it's hard to test it (i'd say you can't test if you are not developer).
If Chromium can be compiled and launched it means it did not break it at least.
Attachments (0)
Change History (5)
Note: See
TracTickets for help on using
tickets.
