Opened on 01/26/2018 at 04:17:06 PM
Closed on 10/12/2018 at 02:41:53 PM
Last modified on 06/10/2019 at 01:49:23 PM
#6328 closed change (fixed)
Move all icons into skin/icons directory in adblockplusui
| Reported by: | greiner | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | #6327, #6936 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/149 |
||
Description (last modified by greiner)
Background
See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/205
What to change
See https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/205
Notes for dependency update
Update mapping for the following files:
- skin/mobile/* to skin/icons/mobile/*
- skin/social/* to skin/icons/*
- skin/updates/icon-* to skin/icons/updates/*
- skin/abb-logo.png to skin/icons/abb-logo.png
- skin/abp-64.png to skin/icons/abp-64.png
- skin/abp-128.png to skin/icons/abp-128.png
- skin/abp-logo.svg to skin/icons/abp-logo.svg
Hints for testers
None of the following images should be missing.
Extension:
- 128px extension logo and toolbar icon
Block element dialog:
- Adblock Plus logo
Bubble UI:
- Adblock Plus logo
Desktop options page:
- Adblock Plus logo
- Facebook, Google+ and Twitter icons in Help tab
Issue reporter:
- Adblock Plus logo
Mobile options page:
- Adblock Plus logo
- Checkmark icon in "Add filter list" dialog
- Toggle button
Updates page:
- Adblock Plus logo
- Background image
- Feature icons
Attachments (0)
Change History (9)
comment:2 Changed on 09/25/2018 at 05:18:16 PM by greiner
- Description modified (diff)
- Summary changed from Reorganize social images in adblockplusui to Move all icons into skin/icons directory in adblockplusui
Updated ticket to move all icons to the icons directory.
comment:4 Changed on 10/11/2018 at 10:49:49 AM by greiner
- Owner set to greiner
comment:5 Changed on 10/11/2018 at 11:38:13 AM by greiner
- Blocking 6936 added
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 10/11/2018 at 11:48:45 AM by greiner
- Description modified (diff)
Added hints for testers.
comment:7 Changed on 10/12/2018 at 02:41:53 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 05/20/2019 at 10:58:32 AM by abpbot
A commit referencing this issue has landed:
Issue 6328 - Moved all icons into skin/icons directory
comment:9 Changed on 06/10/2019 at 01:49:23 PM by ukacar
- Verified working set
Added further changes and notes for dependency update.