Opened on 01/29/2018 at 11:15:42 AM
Closed on 02/08/2018 at 10:35:14 AM
Last modified on 02/16/2018 at 09:05:20 PM
#6335 closed change (fixed)
[ABP for Samsung Internet] - Update translations for "Samsung Internet"
| Reported by: | Shikitita | Assignee: | jwangenheim |
|---|---|---|---|
| Priority: | Unknown | Milestone: | Adblock-Plus-for-Samsung-Browser-1.1.3 |
| Module: | Adblock-Plus-for-Samsung-Browser | Keywords: | |
| Cc: | jwangenheim, mario | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): | |||
Description
Background
When we launched ABP for Samsung Internet, the official translation for "Samsung Internet" was "Samsung Internet" in all languages except Korean. However, it seems this is no longer the case.
What to change
"Samsung Internet" has been translated into Italian, Russian and Spanish and therefore should be updated in the relevant strings for ABP for Samsung Internet.
The new text is as follows:
Italian: Internet Samsung
Russian: Интернет Samsung
Spanish: Internet de Samsung
The affected strings would be:
app_name
sbrowser_dialog_title
sbrowser_dialog_message
setup_dialog_title
setup_dialog_message_sbrowser_4
setup_dialog_message_sbrowser_5
setup_dialog_button
Attachments (0)
Change History (6)
comment:1 Changed on 02/02/2018 at 11:20:02 AM by jwangenheim
- Owner set to jwangenheim
comment:2 Changed on 02/08/2018 at 10:31:09 AM by abpbot
comment:3 Changed on 02/08/2018 at 10:35:07 AM by jwangenheim
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 02/08/2018 at 10:35:14 AM by jwangenheim
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 02/08/2018 at 10:35:52 AM by jwangenheim
- Milestone set to Adblock-Plus-for-Samsung-Browser-1.1.3
comment:6 Changed on 02/16/2018 at 09:05:20 PM by rscott
- Verified working set
A commit referencing this issue has landed:
Issue 6335 - Update translations for 'Samsung Internet'