Opened on 01/29/2018 at 03:36:30 PM

Last modified on 10/08/2019 at 06:04:08 PM

#6337 new defect

CMS test server is case insensitive

Reported by: juliandoucette Assignee: atudor
Priority: P3 Milestone:
Module: Sitescripts Keywords:
Cc: kvas, jsonesen Blocked By: #7019
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

Description

Environment

OS X, brew python + dependencies installed by pip.

How to reproduce

  1. Add a page to any website containing an image with a path that includes (or doesn't include) a capital letter
  2. Place an image at the path specified on the page except change the case of any letter in the file name

Observed behaviour

The image will display (no matter the case).

Expected behaviour

The image should be case sensitive or configurable to be case sensitive or not (because our production systems are case sensitive and mercurial will not recognize a file name case change as a change on filesystems that are not case sensitive).

Attachments (0)

Change History (6)

comment:1 Changed on 01/29/2018 at 04:25:27 PM by kvas

  • Priority changed from Unknown to P3
  • Ready set

Implementation notes:

  • Unfortunately (or maybe fortunately...) this bug is only visible on Mac OS X (the file system of Mac OS X is case-insensitive), so whoever works on this ticket would need a Mac.
  • We should add a couple of tests, using an image and a page with a name that contains one capital letter and an expected output (indicating that the page/image is missing) for the same name with all small letters. This should fit well in the test_page_outputs.py framework and will also allow us to test 404 errors in the server.
  • Here's ​a post with some ideas about how to do case detection in filenames.
  • Be careful to not break the correct handling of multiple files that only differ by letter case on case-sensitive filesystems. Perhaps we could add a test for it that would be skipped on Mac OS X (since it would fail there). Unfortunately this would require more serious extensions to test_page_outputs.py.

comment:2 Changed on 10/04/2018 at 01:55:49 PM by atudor

  • Owner set to atudor

comment:3 Changed on 10/04/2018 at 02:15:18 PM by atudor

  • Blocked By 7019 added

comment:4 Changed on 04/30/2019 at 05:53:23 AM by denniskemp

spam

Last edited on 10/08/2019 at 06:04:05 PM by kzar

comment:5 Changed on 06/12/2019 at 10:34:55 AM by michaeljohn

spam

Last edited on 10/08/2019 at 06:04:08 PM by kzar

comment:6 Changed on 09/17/2019 at 12:27:03 PM by kvas

Dear stakeholders of this ticket,

I'm cleaning up Sitescripts tickets in Trac due to its phase out. This is one of the tickets that I could not myself close or move, so I need your input on it.

Please let me know if this ticket is still relevant for you and we can then discuss where it should be moved. If you think that this ticket is no longer relevant, you can write a comment explaining this or just ignore this message.

If I see now comments in the ticket on October 14, I will close it as rejected.

Best regards,
Vasily

Add Comment

Modify Ticket

Change Properties
Action
as new .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from atudor.
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.