Opened on 02/05/2018 at 05:20:31 PM
Closed on 08/29/2019 at 05:43:18 PM
#6357 closed change (rejected)
Don't suggest element hiding filters if we can't hide elements on the page
| Reported by: | greiner | Assignee: | |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Platform | Keywords: | closed-in-favor-of-gitlab |
| Cc: | kzar, sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by greiner)
Background
Using the "Block element" feature we allow the use to create filters to block or hide elements on the page.
However, there are situations when the extension doesn't add its styles because either element hiding is disabled by a filter or we cannot apply element hiding rules to the page (e.g. #1770). Disabling the feature altogether for such pages (as we do for non-HTTP(S) pages) is not a solution though because request filters still work.
What to change
Don't suggest any element hiding filters in the "Block element" dialog if we cannot apply element hiding rules to the page and allow the UI to show a message explaining why.
Attachments (0)
Change History (3)
comment:1 Changed on 09/28/2018 at 01:24:39 PM by greiner
- Description modified (diff)
- Summary changed from Don't suggest element hiding filters if we can't create a shadow root to Don't suggest element hiding filters if we can't hide elements on the page
comment:2 Changed on 09/28/2018 at 04:04:11 PM by sebastian
- Priority changed from Unknown to P3
- Ready set
comment:3 Changed on 08/29/2019 at 05:43:18 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
Updated ticket to make it independent of how element hiding rules are applied.