Opened on 02/09/2018 at 10:23:23 AM

Closed on 03/29/2018 at 08:43:36 AM

Last modified on 04/13/2018 at 02:54:53 PM

#6373 closed change (fixed)

Remove calling GetHostFromURL()

Reported by: asmirnov Assignee:
Priority: P3 Milestone:
Module: Adblock-Plus-for-Chromium Keywords:
Cc: Blocked By:
Blocking: Platform: Android
Ready: no Confidential: no
Tester: Rraceanu Verified working: yes
Review URL(s):

​https://gitlab.com/eyeo/adblockplus/chromium/merge_requests/6

Description (last modified by asmirnov)

Background

Because of #6372 we should avoid calling not required methods as they can take unpredictable time dependent on current state (updating/parsing/other JS methods invoking at the same time).

What to change

Remove calling GetHostFromURL() in chrome_network_delegate.cc

Attachments (0)

Change History (5)

comment:1 Changed on 02/09/2018 at 10:29:45 AM by asmirnov

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 02/09/2018 at 10:29:59 AM by asmirnov

  • Description modified (diff)

comment:3 Changed on 03/15/2018 at 07:53:37 AM by asmirnov

  • Review URL(s) modified (diff)

comment:4 Changed on 03/29/2018 at 08:43:36 AM by asmirnov

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:5 Changed on 04/13/2018 at 02:54:53 PM by rraceanu

  • Tester changed from Unknown to Rraceanu
  • Verified working set

No calls made to extract host/GetHostFromURL are being made on AdblockChromium dev-64.0.3249.2

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from (none).
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.