Opened on 02/12/2018 at 10:27:46 AM
Closed on 08/29/2019 at 05:43:52 PM
#6378 closed change (rejected)
[emscripten] Make DependentString constexpr
| Reported by: | sergz | Assignee: | rjeschke |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | hfiguiere | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Background
We do use a certain number of string literals as a source for immutable DependentString and sometimes we have to introduce some fundamental helper functions like LENGTH_OF what can be avoided by constexpr variables and classes.
What to change
Change String and DependentString in accordance with the requirements to constexpr variables, functions and constructors and adjust the related variables in the code.
Consider removing the function (or macro what ever will be there later) LENGTH_OF mentioned above if it's not used anymore.
Attachments (0)
Change History (4)
comment:1 Changed on 02/12/2018 at 10:28:01 AM by sergz
- Priority changed from Unknown to P3
comment:2 Changed on 03/14/2018 at 03:44:43 PM by rjeschke
- Owner set to rjeschke
comment:3 Changed on 03/14/2018 at 03:53:28 PM by rjeschke
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.