Opened on 02/13/2018 at 02:28:36 PM
Closed on 04/19/2018 at 11:57:43 AM
Last modified on 04/19/2018 at 12:03:26 PM
#6382 closed defect (fixed)
:-abp-contains() + div not working in Firefox
| Reported by: | arthur | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Platform | Keywords: | |
| Cc: | hfiguiere, easylist.polish@gmail.com, mapx, amrmak, kzar, sebastian, Ross | Blocked By: | |
| Blocking: | Platform: | Firefox | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
Environment
Windows 10
Firefox 58.0.2 (64 bits)
ABP 3.0.2.1969beta
How to reproduce
- Add wp.pl#?#div:-abp-contains(REKLAMA) + div as a custom rule to ABP
- Go to https://www.wp.pl/
Observed behaviour
Ad at the top below "REKLAMA" label doesn't disappear.
Expected behaviour
Ad at the top below "REKLAMA" label should disappear.
Notes
This seems to work fine in Chrome.
Attachments (0)
Change History (13)
comment:1 Changed on 02/13/2018 at 02:29:21 PM by arthur
- Cc easylist.polish@gmail.com added
comment:2 Changed on 02/13/2018 at 10:38:28 PM by hfiguiere
- Owner set to hfiguiere
comment:3 Changed on 02/14/2018 at 04:53:49 PM by mapx
- Cc mapx added
comment:4 Changed on 03/02/2018 at 03:09:06 PM by hfiguiere
- Keywords circumvention added
comment:5 Changed on 03/08/2018 at 06:50:40 PM by amrmak
- Cc amrmak added
comment:6 Changed on 03/09/2018 at 03:52:52 AM by hfiguiere
Simpler test case:
Use filter testpages.adblockplus.org#?#h3:-abp-contains(Test case) + div
And then go to https://testpages.adblockplus.org/en/testcases/css/02
If "Test image" is visible then the filter isn't applied. Works fine in Chrome. Fail in Firefox.
comment:8 Changed on 03/15/2018 at 09:45:31 PM by hfiguiere
- Status changed from new to reviewing
comment:9 Changed on 03/19/2018 at 04:41:51 PM by kzar
Fro the discussion in IRC this sounds like a recent regression. If so please could you add a note about that in the issue description, linking to the commit and explaining what happened?
comment:10 Changed on 03/19/2018 at 04:42:48 PM by kzar
- Cc kzar sebastian Ross added
- Keywords circumvention removed
- Priority changed from Unknown to P1
- Ready set
comment:11 Changed on 03/19/2018 at 10:40:53 PM by sebastian
From the discussion on IRC (see below), it actually doesn't seem to be a regression.
Posted on #adblockplus:
14:11:40 <_hub_> snoack: I believe it is not a regression
Sent to me privately:
14:27:59 <rossg> I see the same with 3.0.2. [...]
If it would be a regression, I'd agree with P1 and think that this should block the 3.0.3 release. Otherwise, P2 and aiming to fix this with Adblock Plus 3.1 should be fine.
comment:12 Changed on 04/19/2018 at 11:56:12 AM by abpbot
A commit referencing this issue has landed:
Issue 6382 - Catch InvalidAccessError exception when checking styles.
comment:13 Changed on 04/19/2018 at 11:57:43 AM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
For the record there is a better filter, but it require to have the fix for issue #6296:
wp.pl#?#:-abp-has(> div:-abp-contains(REKLAMA))
This one should work too.