Opened on 02/14/2018 at 11:01:32 PM

Closed on 02/16/2018 at 12:21:21 AM

#6392 closed change (fixed)

Fix capitalization and trim surrounding whitespace when adding to the whitelist

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29697686/

Description (last modified by dzhang)

Background

A host added to the users whitelisted does not get unblocked if the case is not lower case.

Extraneous whitespace may also be a problem when adding a host to the whitelist from user input.

What to change

  • Set the host name to all lowercase letters
  • Trim whitespace around the added host string

Attachments (0)

Change History (4)

comment:1 Changed on 02/14/2018 at 11:01:57 PM by dzhang

  • Summary changed from Fix capitalization during adding host to whitelist and trim whitespace to Fix capitalization when adding a host to the whitelist and trim whitespace

comment:2 Changed on 02/14/2018 at 11:04:05 PM by dzhang

  • Description modified (diff)
  • Summary changed from Fix capitalization when adding a host to the whitelist and trim whitespace to Fix capitalization and trim surrounding whitespace when adding to the whitelist

comment:3 Changed on 02/15/2018 at 12:44:21 AM by dzhang

  • Review URL(s) modified (diff)

comment:4 Changed on 02/16/2018 at 12:21:21 AM by dzhang

  • Resolution set to fixed
  • Status changed from new to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from dzhang.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.