Opened on 02/16/2018 at 03:02:39 PM
Closed on 11/23/2018 at 01:03:32 PM
Last modified on 06/05/2019 at 01:26:30 PM
#6397 closed change (fixed)
Implement language dropdown
| Reported by: | greiner | Assignee: | agiammarchi |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | jeen | Blocked By: | |
| Blocking: | #6936 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/3 |
||
Description (last modified by greiner)
Background
The initial version of the new options page shipped without the drop-down field for selecting the default language but instead reuses the language selection dialog for that.
In an effort to finish up loose ends, we need to bring the implementation to the same state as the spec.
See also https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/issues/84
What to change
Attachments (0)
Change History (15)
comment:1 Changed on 02/16/2018 at 03:05:39 PM by agiammarchi
- Owner set to agiammarchi
comment:2 Changed on 02/21/2018 at 05:04:30 PM by saroyanm
- Cc jeen added
comment:3 Changed on 02/21/2018 at 05:28:13 PM by agiammarchi
FYI there is an isolated implementation of the current bitbucket specs in here: https://webreflection.github.io/eyeo/tmp-listbox/
comment:5 Changed on 02/22/2018 at 08:56:12 AM by jeen
Updated the link to the GitLab version.
comment:7 Changed on 08/27/2018 at 03:47:31 PM by greiner
- Description modified (diff)
Added links to GitLab issue and spec.
comment:8 Changed on 09/07/2018 at 02:32:38 PM by greiner
- Blocking 6936 added
comment:9 Changed on 09/13/2018 at 10:30:19 AM by abpbot
A commit referencing this issue has landed:
Issue 6397 - Implement language dropdown component
comment:10 Changed on 11/23/2018 at 01:03:32 PM by greiner
- Resolution set to fixed
- Status changed from new to closed
comment:11 Changed on 05/16/2019 at 12:05:30 PM by greiner
- Review URL(s) modified (diff)
comment:12 Changed on 05/20/2019 at 10:58:52 AM by abpbot
A commit referencing this issue has landed:
Issue 6397 - Implement language dropdown
comment:13 Changed on 05/21/2019 at 10:26:03 AM by kzar
- Blocking 6936 removed
comment:14 Changed on 05/21/2019 at 11:18:21 AM by kzar
- Blocking 6936 added
comment:15 Changed on 06/05/2019 at 01:26:30 PM by ukacar
- Verified working set
@Jeen: can you please let us know if we still planing to use current widget, if so can you please update the link to link to the Gitlab version, because I can't find this widget there so far.