Opened on 02/28/2018 at 02:53:31 PM
Closed on 03/12/2018 at 11:52:39 AM
Last modified on 04/05/2018 at 10:22:41 AM
#6432 closed defect (fixed)
Regression: Hide remove button for additional filter lists
| Reported by: | greiner | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | wspee, saroyanm, agiammarchi, jeen, Ross, kzar | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description
Background
While going through the old options page for #6431, I found that we're no longer using the "additional_subscriptions" preference in the new options page.
We expose this preference to administrators so that they can preinstall certain filter lists. It is used for hiding the "remove" button for filter lists which have been added this way.
What to change
Hide any UI related to removing a filter list for those that are listed in the "additional_subscriptions" preference.
See also implementation in old options page.
Attachments (1)
Change History (11)
comment:1 Changed on 03/01/2018 at 12:26:17 PM by saroyanm
- Owner set to saroyanm
comment:2 Changed on 03/01/2018 at 09:53:40 PM by saroyanm
- Cc Ross kzar added
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:4 in reply to: ↑ 3 Changed on 03/02/2018 at 04:30:39 PM by saroyanm
Replying to jeen:
Thanks Jeen, just a note:
I would suggest the following:
- For filter list table in the advanced tab - remove bin icon, and disable toggle switch.
Seem like in old implementation it was still possible to disable/enable the subscription, but not remove it.
I think we should keep toggle button the way it was, but still remove the bin icon and "remove" item from the context menu.
comment:5 Changed on 03/02/2018 at 05:07:13 PM by greiner
This ticket is about restoring the expected behavior of the filter lists table. Therefore let's move the discussion about how newly introduced parts of the UI are supposed to behave to spec#154.
comment:6 Changed on 03/05/2018 at 11:32:15 AM by jeen
Wasn't aware that you could still enable/ disable the filter list - in that case, you are correct @saroyanm, and let's leave the toggle as it is.
Changed on 03/06/2018 at 02:33:54 PM by saroyanm
New color #b3b3b3
comment:7 in reply to: ↑ 3 Changed on 03/06/2018 at 03:21:21 PM by saroyanm
Replying to jeen:
I would suggest the following:
- For items with a checkbox - grey out the checkbox so that it is inactive.
As a result of this, I've created a ticket -> https://gitlab.com/eyeo/specs/spec/issues/155
I'll handle that separately after this issue, after I have a guidance in the gitlab ticket, or updated specs.
comment:8 Changed on 03/12/2018 at 11:48:39 AM by abpbot
A commit referencing this issue has landed:
Issue 6432 - Hide/disable remove buttons for additional filter lists
comment:9 Changed on 03/12/2018 at 11:52:39 AM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:10 Changed on 04/05/2018 at 10:22:41 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Fixed. Remove buttons for subscriptions added via the additional filter lists setting have been removed.
Chrome 65 / Ubuntu 16.04
I would suggest the following: