Opened on 03/08/2018 at 04:28:49 PM
Closed on 08/29/2019 at 05:43:18 PM
#6455 closed change (rejected)
Use tabs.removeCSS on Chromium
| Reported by: | mjethani | Assignee: | mjethani |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Platform | Keywords: | closed-in-favor-of-gitlab |
| Cc: | kzar, sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by mjethani)
Background
We decided to use tabs.removeCSS specifically only on Firefox, because Chromium's implementation was likely to be different and possibly initially buggy. We now know that the API is going to be the same, with the following differences in behavior:
- An extension can only remove its own style sheets
- Injecting the same style sheet twice is not an error, instead a duplicate copy is injected; removing a style sheet only removes the last injected copy
Once the API is in Canary and is stable, we should start using it.
What to change
- Remove the check for Gecko in lib/cssInjection.js, instead use feature detection
- Since Chrome injects multiple copies instead of throwing an error, take care not to inject a duplicate (for this we may have to remove first instead of adding first as we are doing now)
Attachments (0)
Change History (6)
comment:1 Changed on 03/08/2018 at 04:29:53 PM by mjethani
- Cc kzar sebastian added
comment:3 Changed on 03/08/2018 at 04:36:07 PM by sebastian
- Priority changed from Unknown to P3
- Ready set
comment:4 Changed on 03/08/2018 at 06:09:52 PM by mjethani
- Owner set to mjethani
- Review URL(s) modified (diff)
comment:5 Changed on 03/08/2018 at 06:10:02 PM by mjethani
- Status changed from new to reviewing
comment:6 Changed on 08/29/2019 at 05:43:18 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from reviewing to closed
Note: See
TracTickets for help on using
tickets.
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.