Opened on 03/14/2018 at 02:28:05 PM

Last modified on 11/16/2018 at 01:31:51 PM

#6477 reopened change

Separate done and error callbacks in IFileSystem interface

Reported by: sergz Assignee:
Priority: P3 Milestone:
Module: Libadblockplus Keywords:
Cc: asmirnov Blocked By:
Blocking: #6452, #6537 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29731562/

Description (last modified by sergz)

Background

The current implementation of DefaultFileSystem can call the passed callback twice if there is an exception thrown from the callback, the second time it's called with the error message. It should not happen, the callback should be called exactly once.

What to change

Change the interface (with adding a comment) and implementation of DefaultFileSystem. Make the required adjustments.

Attachments (0)

Change History (12)

comment:1 Changed on 03/15/2018 at 10:16:53 AM by sergz

  • Owner set to sergz

comment:2 Changed on 03/23/2018 at 10:36:55 AM by sergz

  • Description modified (diff)

comment:3 Changed on 03/23/2018 at 10:37:21 AM by sergz

  • Blocking 6452 added

comment:4 Changed on 03/23/2018 at 11:27:28 AM by sergz

  • Review URL(s) modified (diff)

comment:5 Changed on 03/23/2018 at 11:29:14 AM by sergz

  • Status changed from new to reviewing

comment:6 Changed on 03/23/2018 at 04:06:47 PM by abpbot

A commit referencing this issue has landed:
​Issue 6477 - separate done and error callbacks in IFileSystem::Read

comment:7 Changed on 03/23/2018 at 04:07:12 PM by sergz

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:8 Changed on 03/29/2018 at 11:48:33 AM by sergz

  • Resolution fixed deleted
  • Status changed from closed to reopened

Basically, all other functions should be addressed too, in particular Stat is very similar to Read.

comment:9 Changed on 03/29/2018 at 11:48:38 AM by sergz

  • Owner sergz deleted

comment:10 Changed on 03/29/2018 at 11:48:50 AM by sergz

  • Priority changed from P2 to P3

comment:11 Changed on 05/21/2018 at 02:10:33 PM by oleksandr

  • Blocking 6537 added

comment:12 Changed on 11/16/2018 at 01:31:51 PM by sergz

  • Cc asmirnov added

Add Comment

Modify Ticket

Change Properties
Action
as reopened .
as The resolution will be set. Next status will be 'closed'.
to The owner will be changed from (none).
Next status will be 'reviewing'.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.