Opened on 03/16/2018 at 11:22:12 AM
Closed on 03/19/2018 at 01:39:30 PM
#6489 closed defect (fixed)
Initializing of scheduler in the DefaultPlatformBuilder does not allow to use it properly
| Reported by: | sergz | Assignee: | sergz |
|---|---|---|---|
| Priority: | P1 | Milestone: | |
| Module: | Libadblockplus | Keywords: | |
| Cc: | asmirnov, hfiguiere | Blocked By: | |
| Blocking: | #6466 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by sergz)
The way it's implemented right now one cannot use DefaultPlatformBuilder::GetDefaultAsyncExecutor for custom implementation of the interfaces because it's empty, the return value is created only when one calls DefaultPlatformBuilder::CreatePlatform, what should be the last call.
FYI, if one firstly calls DefaultPlatformBuilder::CreatePlatform then one cannot anymore set custom interfaces because it's already too late, the instance of Platform is created.
Attachments (0)
Change History (8)
comment:1 Changed on 03/16/2018 at 11:26:13 AM by asmirnov
comment:2 Changed on 03/16/2018 at 11:30:28 AM by asmirnov
- Blocking 6466 added
comment:3 Changed on 03/18/2018 at 07:52:03 AM by asmirnov
i've tested it with libadblockplus-android and it works now. Please submit code review asap
comment:4 Changed on 03/19/2018 at 10:22:30 AM by sergz
- Status changed from new to reviewing
comment:7 Changed on 03/19/2018 at 01:27:44 PM by abpbot
A commit referencing this issue has landed:
Issue 6489 - fix initialization moment of the default scheduler of DefaultPlatformBuilder
comment:8 Changed on 03/19/2018 at 01:39:30 PM by sergz
- Resolution set to fixed
- Status changed from reviewing to closed
Also CreateDefaultFileSystem() requires defaultScheduler to be already created and it's created in CreatePlatform().
So it forces to call CreatePlatform() first.