Opened on 03/22/2018 at 06:14:52 PM
Closed on 05/29/2018 at 05:08:15 PM
Last modified on 08/06/2018 at 06:15:33 PM
#6514 closed change (fixed)
IOToggle Custom Element
| Reported by: | agiammarchi | Assignee: | agiammarchi |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | User-Interface | Keywords: | UI, UX, component |
| Cc: | greiner, saroyanm | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): |
https://codereview.adblockplus.org/29730644/ |
||
Description (last modified by saroyanm)
Background
We agreed on moving away from the current monolith approach to a more flexible, easier to debug, test, or update, components for our common needs.
Now that https://issues.adblockplus.org/ticket/6487 has been merged, it's time to start creating accessible Custom Elements for all new UI components we need (language list, tooltip, infinite filters, etc).
Being a fresh new approach, I suggest we start from most basic elements, trying to improve all of them for both development and for UX experience.
What to do
Convert existing Toggle element into a separate component.
Attachments (0)
Change History (7)
comment:1 Changed on 03/22/2018 at 06:15:38 PM by agiammarchi
- Cc greiner saroyanm added
comment:2 Changed on 05/29/2018 at 05:06:26 PM by saroyanm
- Description modified (diff)
- Summary changed from [meta] Create Accessible UI Components to IOToggle Custom Element
comment:3 Changed on 05/29/2018 at 05:06:44 PM by saroyanm
- Owner set to agiammarchi
comment:4 Changed on 05/29/2018 at 05:07:35 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:5 Changed on 05/29/2018 at 05:08:15 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 05/30/2018 at 02:56:11 PM by abpbot
A commit referencing this issue has landed:
Issue 6514 - IOToggle Custom Element
Changed the description to reflect the change we are planing to land into the release.