Opened on 03/24/2018 at 01:38:16 AM

Closed on 03/27/2018 at 12:58:41 AM

#6521 closed change (fixed)

Fix sourcery not using env vars

Reported by: dzhang Assignee: dzhang
Priority: Unknown Milestone:
Module: Adblock-Plus-for-iOS/macOS Keywords:
Cc: Blocked By:
Blocking: Platform: iOS
Ready: no Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29731628/

Description

Background

It turns out that the yml configuration file for sourcery is not yet able to use environment variables.

Therefore, the previous command line implementation should be restored.

What to change

Restore sourcery command line usage

Additionally, the generated API data file should be prevented from being committed using

git update-index --assume-unchanged Generated/ABPAPIData.swift

Attachments (0)

Change History (2)

comment:1 Changed on 03/26/2018 at 03:20:16 AM by dzhang

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 03/27/2018 at 12:58:41 AM by dzhang

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from dzhang.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.