Opened on 03/28/2018 at 02:55:29 AM
Closed on 05/15/2018 at 08:52:43 PM
Last modified on 09/18/2018 at 11:30:45 AM
#6532 closed change (fixed)
Remove subscription title input field when adding filterlists by url
| Reported by: | jsonesen | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | greiner, sebastian | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by greiner)
Background
Currently when subscribing to a new filterlist the user is required to enter a title for the name of the list, but once the subscription is added the title input by our users is overwritten by the title given to the list by the authors.
See also https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/38
What to change
- Remove the input field for the filter list title from desktop-options.html and update any parts in the code that refer to it
- Remove the strings "options_dialog_import_subscription_title" and "options_dialog_import_subscription_title_error"
Attachments (0)
Change History (12)
comment:2 Changed on 03/30/2018 at 03:47:24 AM by jsonesen
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 03/31/2018 at 06:57:01 PM by sebastian
- Cc sebastian added
comment:4 Changed on 04/03/2018 at 02:00:38 PM by greiner
- Description modified (diff)
- Priority changed from Unknown to P3
- Ready set
comment:5 Changed on 05/15/2018 at 08:52:43 PM by jsonesen
- Resolution set to fixed
- Status changed from reviewing to closed
comment:6 Changed on 05/16/2018 at 11:05:39 AM by greiner
comment:7 Changed on 05/30/2018 at 02:56:11 PM by abpbot
A commit referencing this issue has landed:
Issue 6532 - Removes required subscription title input field
comment:8 Changed on 07/10/2018 at 08:48:12 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Appears to be working as expected.
ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7
comment:9 Changed on 07/10/2018 at 08:51:27 AM by Ross
Something I did notice while testing this however: The title=<> param from an abp:subscribe link takes precedence over any title set in the subscription file itself (using ! Title: <>). Is that correct?
comment:10 Changed on 07/10/2018 at 09:38:55 AM by greiner
No, it shouldn't. The title provided within the filter list should always take precedence so thanks for pointing that out.
Mind creating a ticket for that issue?
comment:11 follow-up: ↓ 12 Changed on 09/17/2018 at 08:58:16 PM by SMed79
Are you planning to remove the input field for the filter list title from "_mobile-options.html_"?
comment:12 in reply to: ↑ 11 Changed on 09/18/2018 at 11:30:45 AM by greiner
Replying to SMed79:
Are you planning to remove the input field for the filter list title from "_mobile-options.html_"?
Yes and no.
The title input field has been removed in #6760 which is going to be included in the next update.
We do, however, keep showing the title when adding a language filter list as those use the same dialog. This is just a temporary solution though because removing it would require changing the user flow there to avoid the dialog.
There are no plans yet on whether or not this should be done so feel free to suggest an approach in a new ticket.
See https://gitlab.com/eyeo/adblockplus/adblockplusui/commit/f3b8edbf8ab20e9a1dc40a12e1eefa2249f7e24c