Opened on 03/31/2018 at 10:35:14 AM

Closed on 04/04/2018 at 11:04:39 AM

Last modified on 04/05/2018 at 08:20:04 AM

#6542 closed defect (fixed)

Blocked / whitelisted URLs are not coloured red / green in devtools panel

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: User-Interface Keywords:
Cc: Ross, sebastian, greiner, saroyanm, agiammarchi Blocked By:
Blocking: #6548 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Ross Verified working: yes
Review URL(s):

​https://codereview.adblockplus.org/29738571/

Description (last modified by kzar)

Environment

Adblock Plus devbuild from ​7eeecf6e1a1d, Chrome 65, EasyList (AA disabled).

How to reproduce

  1. Open a new tab, open the developer tools for it and switch to the Adblock Plus pane.
  2. Select "Blocked" to view only blocked requests
  3. Browse to ​https://reddit.com

Observed behaviour

While the blocked requests are mostly coloured red, the URL isn't. (See screenshot attached.)

Expected behaviour

The URL should be coloured red too.

Notes

  • This is a regression from ​d414ee80d886.
  • It also applies to whitelisted requests.

Hints for testers

Test that the colours of blocked, whiteslisted and regular resources all look correct in our developer tools pane. Test with both the regular and dark theme.

Attachments (1)

blocked-url-colour.png​ (68.2 KB) - added by kzar on 03/31/2018 at 10:43:44 AM.

Download all attachments as: .zip

Change History (9)

Changed on 03/31/2018 at 10:43:44 AM by kzar

comment:1 Changed on 03/31/2018 at 11:08:09 AM by kzar

  • Description modified (diff)
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/03/2018 at 05:48:43 PM by greiner

  • Priority changed from Unknown to P3
  • Ready set

comment:3 Changed on 04/04/2018 at 09:26:45 AM by kzar

  • Blocking 6518 added

comment:4 Changed on 04/04/2018 at 10:31:07 AM by abpbot

A commit referencing this issue has landed:
​Issue 6542 - Fix the colours of the devtools resource URLs

comment:5 Changed on 04/04/2018 at 10:53:12 AM by kzar

  • Blocking 6548 added

comment:6 Changed on 04/04/2018 at 11:04:39 AM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

comment:7 Changed on 04/04/2018 at 11:15:18 AM by kzar

  • Blocking 6518 removed

comment:8 Changed on 04/05/2018 at 08:20:04 AM by Ross

  • Tester changed from Unknown to Ross
  • Verified working set

Fixed.

ABP 3.0.2.2002
Firefox 51 / 58 / Windows 7
Chrome 49 / 65 / Windows 7
Opera 36 / 51 / Windows 7

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.