Opened on 04/06/2018 at 02:36:56 PM

Closed on 06/04/2018 at 05:55:57 PM

#6562 closed change (fixed)

Remove provideFilterKeys parameter from getSelectorsForDomain and associated logic

Reported by: kzar Assignee: kzar
Priority: P3 Milestone:
Module: Core Keywords:
Cc: mjethani, sergz Blocked By:
Blocking: Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

​https://codereview.adblockplus.org/29757584/
​https://codereview.adblockplus.org/29757588/
​https://codereview.adblockplus.org/29757591/

Description (last modified by kzar)

Background

After a ​discussion in a codereview Manish and I realized the provideFilterKeys parameter for the getSelectorsForDomain function is no longer required. Additionally along with the changes for #6559 to replace Objects with Maps and Sets this means we can get rid of those keys all together.

What to change

  • Remove the provideFilterKeys parameter for the getSelectorsForDomain function.
  • Remove the unused getSelectors function.
  • Remove filter keys, since we can now use the filters themselves as they keys in lookups.

Attachments (0)

Change History (4)

comment:1 Changed on 04/20/2018 at 06:48:51 PM by kzar

  • Description modified (diff)
  • Ready set
  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:2 Changed on 04/23/2018 at 11:06:24 AM by abpbot

Some commits referencing this issue have landed:

comment:3 Changed on 05/04/2018 at 01:30:07 PM by abpbot

A commit referencing this issue has landed:
​Issue 6562 - Remove filter keys from the element hiding code

comment:4 Changed on 06/04/2018 at 05:55:57 PM by kzar

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from kzar.
Attachments ↑ Description ↑
 
Note: See TracTickets for help on using tickets.