Opened on 04/21/2018 at 12:40:11 AM
Closed on 05/15/2018 at 08:50:10 PM
#6605 closed change (fixed)
Add support for bookmark specific expected outputs to CMS tests.
| Reported by: | jsonesen | Assignee: | jsonesen |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Sitescripts | Keywords: | CMS |
| Cc: | sebastian, kvas, rhowell | Blocked By: | |
| Blocking: | #5618, #6545 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kvas)
Background
While testing #6545 I ran into a problem with the tests where sitemap.tmpl renders differently based on the bookmark the site is generated from (this functionality was added with #4992). Adding bookmark specific expected outputs will also be handy with #5618 as well, since static content links are generated with a special character ? and the revision number that link is from.
What to change
Change the test suite's expected output parsing to support the addition of a delimiting character for bookmark specific outputs following the test_type character.
Note
I have implemented this already in this review but realized it would be much better to have a separate ticket, so that I can add some documentation around this as well without muddying up the patch.
Attachments (0)
Change History (4)
comment:2 Changed on 04/25/2018 at 09:16:06 AM by kvas
comment:3 Changed on 04/26/2018 at 01:16:52 AM by jsonesen
Wouldn't this ticket actually be blocked by 6545? Since it needs to land with the test suite changes first, then the doc added?
comment:4 Changed on 05/15/2018 at 08:50:10 PM by jsonesen
- Resolution set to fixed
- Status changed from new to closed
I fixed the issue links and added blocked tickets and the review link. Also set it to ready.