Opened on 04/25/2018 at 01:03:43 PM

Closed on 04/30/2018 at 06:02:30 PM

#6625 closed change (fixed)

Enable module switching in webpack, parametrized by metadata.*

Reported by: tlucas Assignee: tlucas
Priority: P3 Milestone:
Module: Automation Keywords:
Cc: sebastian, kzar, oleksandr, geo Blocked By:
Blocking: #6621 Platform: Unknown / Cross platform
Ready: yes Confidential: no
Tester: Unknown Verified working: no
Review URL(s):

https://codereview.adblockplus.org/29762564/

Description (last modified by tlucas)

Background

We occasionally need to switch implementations of a module at build-time, e.g. based on the build target (see #6621 for a current example).

What to change

Expose webpack's resolve.alias mechanism in metadata.* files.

Integration Notes

Since we already refer to the parent's repository's README.md here, make sure to mention webpack's resolve.alias machinery in that README.md, once this change is included into the repositories depending on buildtools.

Attachments (0)

Change History (6)

comment:1 Changed on 04/25/2018 at 01:11:59 PM by sebastian

  • Blocking 6621 added
  • Description modified (diff)
  • Priority changed from Unknown to P3
  • Ready set

comment:2 Changed on 04/25/2018 at 02:51:43 PM by tlucas

  • Owner set to tlucas

comment:3 Changed on 04/30/2018 at 05:27:20 PM by tlucas

  • Review URL(s) modified (diff)
  • Status changed from new to reviewing

comment:4 Changed on 04/30/2018 at 05:56:40 PM by tlucas

  • Description modified (diff)

comment:5 Changed on 04/30/2018 at 06:02:05 PM by abpbot

A commit referencing this issue has landed:
Issue 6625 - Expose webpack's resolve.alias to the packagers

comment:6 Changed on 04/30/2018 at 06:02:30 PM by tlucas

  • Resolution set to fixed
  • Status changed from reviewing to closed

Add Comment

Modify Ticket

Change Properties
Action
as closed .
The resolution will be deleted. Next status will be 'reopened'.
to The owner will be changed from tlucas.
 
Note: See TracTickets for help on using tickets.