Opened on 05/02/2018 at 03:04:23 PM
Closed on 09/07/2018 at 05:24:17 PM
Last modified on 06/05/2019 at 01:18:16 PM
#6641 closed defect (fixed)
Copyright year in about dialog is out of date
| Reported by: | Ross | Assignee: | greiner |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | sebastian, kzar, greiner, juliandoucette, Kai, jeen | Blocked By: | |
| Blocking: | #6936 | Platform: | Unknown / Cross platform |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/abpui/adblockplusui/merge_requests/108 |
||
Description (last modified by greiner)
Environment
ABP 3.0.4.2034
Chrome 66 / Windows 10
How to reproduce
- Select the [About Adblock Plus] link.
Observed behaviour
The dialog displays Copyright © 2017 eyeo GmbH
Expected behaviour
The dialog to display the current year.
What to change
Replace year in copyright notice on first-run page with "2006-present".
Attachments (0)
Change History (9)
comment:1 Changed on 05/02/2018 at 03:39:36 PM by sebastian
- Cc greiner added
comment:2 Changed on 05/02/2018 at 05:23:01 PM by greiner
- Cc juliandoucette Kai added
- Description modified (diff)
I agree, I've also suggested to use the phrasing you suggested for the first-run page (see gitlab#173). Otherwise we could evaluate the year at runtime. Besides that, I'm pretty sure that we don't even need a copyright notice anywhere so we could even think about getting rid of it or at least removing the year from it.
Note that the same issue also exists in the footer of adblockplus.org which the new first-run page is based on so it'd be great if we could have the same fix for UI and Websites.
comment:3 Changed on 05/04/2018 at 11:42:25 AM by greiner
- Cc jeen added
Note that the way it's defined in the spec is
Copyright © {current year} All rights reserved. Adblock Plus® is a registered trademark of [eyeo GmbH](https://eyeo.com).
so the year appears to be expected to be inserted automatically.
comment:4 Changed on 09/07/2018 at 04:17:16 PM by greiner
- Owner set to greiner
- Priority changed from Unknown to P3
- Ready set
comment:5 Changed on 09/07/2018 at 04:28:32 PM by greiner
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:6 Changed on 09/07/2018 at 04:31:14 PM by greiner
- Blocking 6936 added
comment:7 Changed on 09/07/2018 at 05:24:17 PM by greiner
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 05/20/2019 at 10:58:25 AM by abpbot
A commit referencing this issue has landed:
Issue 6641 - Fixed: Year in copyright notice was hardcoded
comment:9 Changed on 06/05/2019 at 01:18:16 PM by ukacar
- Verified working set
For reference this is what we use as copyright notice in the source files and some other places: Copyright (C) 2006-present eyeo GmbH. That way it doesn't need to be updated in the future.