Opened on 05/04/2018 at 02:15:22 PM
Closed on 05/11/2018 at 12:51:17 PM
Last modified on 07/04/2018 at 11:11:07 AM
#6645 closed change (fixed)
Collapse elements through user style sheets if possible
| Reported by: | sebastian | Assignee: | sebastian |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Plus-3.2-for-Chrome-Opera-Firefox |
| Module: | Platform | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by sebastian)
Background
With #5899 we started to collapse <video> and <audio> elements (that don't have <source> or <track> child elements) using a (user) style sheet. However, there are other elements (e.g. images and iframes) that could be hidden based on their src attribute though a style sheet as well.
What to change
Hide elements that have been blocked, by adding a selector matching their src and/or srcset attribute to a style sheet (instead of overriding their style attribute) where applicable.
Attachments (0)
Change History (5)
comment:1 Changed on 05/04/2018 at 02:17:19 PM by sebastian
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:2 Changed on 05/11/2018 at 12:36:51 PM by abpbot
comment:3 Changed on 05/11/2018 at 12:51:17 PM by sebastian
- Description modified (diff)
- Milestone set to Adblock-Plus-for-Chrome-Opera-Firefox-next
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 05/18/2018 at 02:54:16 PM by abpbot
A commit referencing this issue has landed:
Issue 6645 - Collapse elements through user style sheets if possible
comment:5 Changed on 07/04/2018 at 11:11:07 AM by Ross
- Tester changed from Unknown to Ross
- Verified working set
This seems to be working as expected.
ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7
A commit referencing this issue has landed:
Issue 6645 - Collapse elements through user style sheets if possible