Opened on 05/11/2018 at 04:34:35 PM
Closed on 08/29/2019 at 05:43:52 PM
#6664 closed change (rejected)
Update the buildtools dependency for adblockpluscore
| Reported by: | tschuster | Assignee: | tschuster |
|---|---|---|---|
| Priority: | P3 | Milestone: | |
| Module: | Core | Keywords: | closed-in-favor-of-gitlab |
| Cc: | mjethani, kzar, erikvold | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description (last modified by kzar)
Background
Currently adblockpluscore uses a very old buildtools version from 2016 (https://hg.adblockplus.org/buildtools/rev/3816c08c0f98). This even still includes jshdyra, which we don't need anymore with WebExtensions everywherea and the generate_docs.py script seems to be broken. I propose updating the version to what we are already using in adblockpluschrome.
What to change
Update the buildtools dependency to FIXME.
Attachments (0)
Change History (8)
comment:1 Changed on 05/30/2018 at 02:35:03 PM by kzar
- Milestone Adblock-Plus-for-Chrome-Opera-Firefox-next deleted
comment:2 Changed on 05/30/2018 at 02:36:48 PM by kzar
- Cc mjethani kzar added
- Description modified (diff)
- Priority changed from Unknown to P2
- Summary changed from Update adblockpluscore buildtools dependency to Update the buildtools dependency for adblockpluscore
comment:3 Changed on 06/08/2018 at 12:16:39 PM by mjethani
- Priority changed from P2 to P3
- Ready set
comment:5 Changed on 06/12/2018 at 10:48:52 AM by kzar
- Ready unset
comment:6 Changed on 06/21/2018 at 12:51:17 PM by tschuster
The current version is from 2016. I looked through the changesets and I think most of these aren't really relevant for the buildtools, it's mostly about dropping support for Firefox, Safari and thinks like that. I would however
I do have to correct myself, adblockpluschrome also seems to use some old version. I am not sure why I thought adblockpluschrome used that specific version.
comment:7 Changed on 11/15/2018 at 04:32:33 AM by erikvold
- Cc erikvold added
comment:8 Changed on 08/29/2019 at 05:43:52 PM by sebastian
- Keywords closed-in-favor-of-gitlab added
- Resolution set to rejected
- Status changed from new to closed
Sorry, but we switched to GitLab. If this issue is still relevant, please file it again in the new issue tracker.
Please could you update the issue to include the revision you're updating the dependency to? Also please could you go through the changes included to check if any are relevant and list those and check if they have any integration notes?