Opened on 05/16/2018 at 01:28:51 PM
Closed on 05/18/2018 at 03:45:29 PM
Last modified on 07/09/2018 at 12:49:26 PM
#6670 closed change (fixed)
Log URL rewrites in DevTools
| Reported by: | hfiguiere | Assignee: | hfiguiere |
|---|---|---|---|
| Priority: | Unknown | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | kzar, sebastian, greiner, Ross | Blocked By: | |
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | no | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): | |||
Description (last modified by hfiguiere)
Background
In issue #6592, we introduce an option to rewrite URL. We want to have this logged in the DevTools as part of the WebExtension change covered by issue #6622
What to change
- Modify the UI template for filter log
- Add code to populate that template
- Add mockup data
Note
From https://issues.adblockplus.org/ticket/6622#comment:6
Design request in gitlab#76
Attachments (0)
Change History (10)
comment:1 Changed on 05/16/2018 at 01:33:29 PM by hfiguiere
- Status changed from new to reviewing
comment:3 Changed on 05/16/2018 at 01:35:16 PM by hfiguiere
- Cc kzar sebastian mjethani greiner added
comment:4 Changed on 05/16/2018 at 01:36:08 PM by hfiguiere
- Cc Ross added; mjethani removed
comment:5 Changed on 05/17/2018 at 05:30:16 PM by hfiguiere
comment:6 Changed on 05/18/2018 at 03:34:40 PM by greiner
As requested, I've moved the commit to the release branch that's meant to be included in the next extension release (see https://gitlab.com/eyeo/adblockplus/adblockplusui/commit/edb830885ffcb3034ba8c9b5d7ab0b7c408b50c8) because I've originally pushed it to the latest release branch.
comment:7 Changed on 05/18/2018 at 03:45:29 PM by hfiguiere
- Resolution set to fixed
- Status changed from reviewing to closed
comment:8 Changed on 05/22/2018 at 01:02:56 PM by hfiguiere
- Blocking 6622 removed
comment:9 Changed on 05/30/2018 at 02:56:13 PM by abpbot
A commit referencing this issue has landed:
Issue 6670 - Display the rewritten to info if applicable in the devtools
comment:10 Changed on 07/09/2018 at 12:49:26 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. This appears to be working as expected. Rewrites correctly appear in the devtools panel log.
ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7
Pushed into the repository:
https://gitlab.com/eyeo/adblockplus/adblockplusui/commit/5a23e1ad9af64217c15d3c070993784be97785fa
(this is not in the master branch)