Opened on 05/24/2018 at 05:07:09 PM
Closed on 05/29/2018 at 04:46:28 PM
Last modified on 07/11/2018 at 12:33:24 PM
#6697 closed change (fixed)
Use common_notification_hide intead options_notification_hide and issueReporter_notification_hide
| Reported by: | saroyanm | Assignee: | saroyanm |
|---|---|---|---|
| Priority: | P2 | Milestone: | |
| Module: | User-Interface | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Unknown / Cross platform | |
| Ready: | yes | Confidential: | no |
| Tester: | Ross | Verified working: | yes |
| Review URL(s): |
https://gitlab.com/eyeo/adblockplus/adblockplusui/merge_requests/23 |
||
Description
Background
See -> https://gitlab.com/eyeo/adblockplus/adblockplusui/issues/88
What to change
Use common_notification_hide intead options_notification_hide and issueReporter_notification_hide in the Adblock Plus UI
Attachments (0)
Change History (5)
comment:1 Changed on 05/29/2018 at 04:46:17 PM by saroyanm
- Owner set to saroyanm
comment:2 Changed on 05/29/2018 at 04:46:24 PM by saroyanm
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 05/29/2018 at 04:46:28 PM by saroyanm
- Resolution set to fixed
- Status changed from reviewing to closed
comment:4 Changed on 05/30/2018 at 02:56:14 PM by abpbot
comment:5 Changed on 07/11/2018 at 12:33:24 PM by Ross
- Tester changed from Unknown to Ross
- Verified working set
Done. Works as expected.
ABP 3.1.0.2069
Chrome 67 / 64 / 49 / Windows 7
Firefox 60 / 55 / 51 / Windows 7
Opera 52 / 45 / 38 / Windows 7
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6697 - Unify screen readers notification close text