Make the generated malware domain filter list encode domains as Punycode

[sebastian]

Background

Since #6647 (also see the related ​devbuild announcement), we expect domains in filters being encoded as Punycode (instead of Unicode). However, the generated malware domain list ​still encodes domains as Unicode. Hence any filter containing an internationalized domain in the malware domain list won't have any effect in Adblock Plus 3.2 (and above).

What to change

Make the generated malware domain filter list encode domains as Punycode.

[kvas]

@sebastian: are there any timing requirements for this issue? Namely, does it have to be deployed together with ABP 3.2 (which would be the case if ABP currently doesn't understand Punycode) or can it be deployed as soon as done?

[sebastian]

Yeah, before Adblock 3.2, filters with domains given in Punycode won't have any effect, while starting with Adblock Plus 3.2, filters with internationalized domains in Unicode won't have any effect.

So if this change would be deployed close to the Adblock Plus 3.2 release, this would minimize scenarios in which filters don't work as expected. But IMO its not important enough to justify any hassle making sure this change gets deployed at the day of the release.

[abpbot]

A commit referencing this issue has landed:
​Issue 6707 - Make the generated malware domain filter list encode domains as Punycode