Opened on 06/01/2018 at 10:35:46 PM
Closed on 06/05/2018 at 08:35:44 PM
Last modified on 03/20/2019 at 05:27:25 PM
#6723 closed change (fixed)
Adjust branding directory
| Reported by: | diegocarloslima | Assignee: | diegocarloslima |
|---|---|---|---|
| Priority: | P2 | Milestone: | Adblock-Browser-for-Android-1.5.0 |
| Module: | Adblock-Browser-for-Android | Keywords: | |
| Cc: | Blocked By: | ||
| Blocking: | Platform: | Adblock Browser for Android | |
| Ready: | yes | Confidential: | no |
| Tester: | Unknown | Verified working: | no |
| Review URL(s): | |||
Description
There have been some changes in the required branding files since the adblockbrowser branding directory was created. Some files are required now (e.g. drawable-nodpi/firstrun_welcome.png), other files that are there aren't required anymore (e.g. drawable-hdpi/widget_icon.png). We need to adjust our branding directory accordingly. The official branding directory might be used as reference.
Attachments (0)
Change History (8)
comment:1 Changed on 06/01/2018 at 10:42:14 PM by diegocarloslima
- Ready set
comment:2 Changed on 06/01/2018 at 11:06:29 PM by diegocarloslima
- Review URL(s) modified (diff)
- Status changed from new to reviewing
comment:3 Changed on 06/05/2018 at 08:32:12 PM by abpbot
comment:4 Changed on 06/05/2018 at 08:35:44 PM by diegocarloslima
- Resolution set to fixed
- Status changed from reviewing to closed
comment:5 Changed on 08/17/2018 at 10:12:29 PM by diegocarloslima
- Milestone set to Adblock-Browser-for-Android-next
comment:6 Changed on 03/19/2019 at 09:36:21 AM by aboegler
Are there any particular locations where these new icons are used, and that need to be tested?
comment:7 Changed on 03/19/2019 at 04:30:54 PM by diegocarloslima
Currently, there are 3 different resources in the branding directory:
- firstrun_welcome: was supposed to be used in the first run slides, but since we use our own onboarding slides, its not used. Its just there to avoid potential build errors
- icon: is used in several places around the app. The easiest way to verify that the icon resource being used is our own is to check the app icon
- large_icon: looks like this one is not used in the mobile app. But also, its there to avoid any build issues and to be in the safe side of not showing any firefox icon by accident
comment:8 Changed on 03/20/2019 at 05:27:25 PM by aboegler
Thanks Diego!
QA LGTM.
Note: See
TracTickets for help on using
tickets.
A commit referencing this issue has landed:
Issue 6723 - Adjust branding directory